always do chdir after fork otherwise commands can fail with unreachab…

…le location
yast · Oct 17, 2013 · 57fc29a · 57fc29a
1 parent bb3a672
commit 57fc29a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/agent-any/src/AnyAgent.cc b/agent-any/src/AnyAgent.cc
@@ -672,6 +672,10 @@ static FILE* program_stream(const char *s, SCRAgent* agent)
               int res = chroot(agent->root());
               if (res == -1)
                 _exit(1);
+
+              // Do not allow touch outside of chroot especially `cd ~` can
+              // cause errors
+              chdir("/");
             }
             // lets ignore if it fails, we even cannot log here
             setenv ("LC_ALL", "C", 1);

diff --git a/agent-system/src/ShellCommand.cc b/agent-system/src/ShellCommand.cc
@@ -159,6 +159,10 @@ shellcommand ( const string &target_root, const string &command, const string &t
                     // y2error ("chroot failed, errno: %d", errno);
                     _exit(1);
                 }
+
+                // Do not allow touch outside of chroot especially `cd ~` can
+                // cause errors
+                chdir("/");
             }
 
 	    ret = system (command.c_str ());