Merge pull request #54 from yast/fix_segfault_during_install

Fix segfault during install

VERSION

@@ -1 +1 @@
-3.0.1
+3.0.2

base/src/.gitignore

@@ -1,2 +1,4 @@
 scr
 y2base
+*.log
+*.trs

base/src/Makefile.am

@@ -50,3 +50,6 @@ scr_LDFLAGS =                                   \
         $(top_builddir)/scr/src/libpy2scr.la            \
 	$(top_builddir)/wfm/src/libpy2wfm.la		\
         -Xlinker --no-whole-archive
+
+TESTS = scr-smoke-test
+EXTRA_DIST = $(TESTS)

base/src/scr-smoke-test

@@ -0,0 +1,7 @@
+#! /bin/bash
+
+DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
+# smoke test:
+echo "WHEN" "simply run with noting to do"
+echo "  IT" "exits with no error (in particular it does not segfault)"
+$DIR/scr stdio scr < /dev/null

liby2/src/genericfrontend.cc

@@ -772,9 +772,7 @@ main (int argc, char **argv)
     server->result(result);
 
     // Cleanup
-    delete server;
     delete[] server_argv;
-    delete client;
 
     // might be useful in tracking segmentation faults
     y2milestone ("Finished YaST2 component '%s'", progname);

liby2/src/include/y2/Y2ComponentBroker.h

@@ -156,6 +156,10 @@ class Y2ComponentBroker
      * If set to false only servers are created.
      * @return A pointer to the new component if one has been found, 0 if no
      * component matching spec has been found.
+     * Pointer returned by this function is owned by ComponentCreator so do not
+     * delete it at your own.
+     * @see Y2ComponentCreator#create for details what ComponentCreator must
+     * return
      */
     static Y2Component *createComponent(const char *name, bool look_for_clients);
 

package/yast2-core.changes

@@ -1,3 +1,10 @@
+-------------------------------------------------------------------
+Tue Oct  1 14:59:08 UTC 2013 - jreidinger@suse.com
+
+- fixed a segfault at the end of 'scr' program used during the 
+  installation, leading to /core file (BNC#841623)
+- 3.0.2
+
 -------------------------------------------------------------------
 Wed Sep  4 14:24:39 UTC 2013 - mvidner@suse.com