Fix compiler warnings, with explanations #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Since we're comparing for equality with a number of items in the file, casting to unsigned gives the correct result.
link: warning: `-version-info/-version-number' is ignored for convenience libraries liby2foo was formerly linked to y2base, but nowadays libpy2foo (p for plugin) is dlopen'd
| y2debug ("Rewriting %s to %s", sec.c_str(), buf); | ||
| file = buf; | ||
| delete [] buf; | ||
| file = format(rewrites[rb].out.c_str (), sec.c_str()); |
There was a problem hiding this comment.
indentation looks incosistent
by using a previously introduced helper. warning: format not a string literal, argument types not checked [-Wformat-nonliteral]
warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] Luckily, the code did the right thing even if buggy, because S_IXOTH happens to be 1.
warning: ignoring return value of 'int chdir(const char*)', declared with attribute warn_unused_result [-Wunused-result]
if the chroot succeeded then the chdir("/") shouldn't fail anyway
Funnily, (void) system(...) still shows the warning: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509 and the "fix" in GCC was to introduce -Wno-unused-result (which disables all such warnings).
y2changes.cc is mostly duplicated from y2log.cc and will need more cleanup. This partial cleanup only aims to remove the warning about ignoring the return value of system(3).
This gets rid of the warnings: warning: ignoring return value of 'int asprintf(char**, const char*, ...)', declared with attribute warn_unused_result [-Wunused-result] which point to the error case where vasprintf cannot allocate memory and the result is undefined, so the program would likely crash. stringutil::form return an empty string in such case.
|
Updated |
|
LGTM |
mvidner
added a commit
that referenced
this pull request
May 13, 2015
Fix compiler warnings, with explanations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.