boost::logic::tribool requires explicit cast #140
Conversation
Since Boost 1.69.0, tribool -> bool cast is explicit. To minimize changes in Yast2 codebase, re-add this cast explicitly to YCPBoolean
| @@ -98,6 +99,7 @@ class YCPBoolean : public YCPValue | |||
| static YCPBoolean* falseboolean; | |||
|
|
|||
| public: | |||
| YCPBoolean(const boost::logic::tribool &tb) : YCPBoolean((bool)tb) {} | |||
There was a problem hiding this comment.
where is this tribool used? So far I see in core only usage of some trivial string algorithm from boost.
There was a problem hiding this comment.
https://bugzilla.suse.com/show_bug.cgi?id=1128364
so the fixes is either to explicitly cast it there in every usage or provide this cast here.
There was a problem hiding this comment.
I am making a better fix in yast-pkg-bindings.
|
yast/yast-pkg-bindings#112 is IMHO a better fix for this because it is a specific fix for one usage of tribool in the libzypp API. Adding an implicit conversion to YCPBoolean would bite us in unexpected times. (Also, yast-core does not care about tribools anywhere else) @AdamMajer anyway, thanks for the bug report and for the PR! |
|
Thank you for fixing this. |
Since Boost 1.69.0, tribool -> bool cast is explicit.
To minimize changes in Yast2 codebase, re-add this
cast explicitly to YCPBoolean
This should fix https://bugzilla.suse.com/show_bug.cgi?id=1128364