Fixes for gensalt handling with libxcrypt. #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
besser82
force-pushed
the
topic/besser82/libxcrypt_fixes
branch
2 times, most recently
from
128c516
to
afb46d3
Compare
besser82
force-pushed
the
topic/besser82/libxcrypt_fixes
branch
from
afb46d3
to
476e711
Compare
|
@besser82 thanks for your patch. I took us some time to check it as it is critical part and cryptography is always a bit scary. Also code is not so clear if we use libxcrypt or libowcrypt. So I check this and also pr to ruby-bindings. I found that we no longer use those builtins from core, so I will create pull request that will drop it and also its dependency, so faster building. Thanks for pointing us to this code. |
Merged
|
so replaced by #149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
libxcryptlibrary in version >= 4 offers support for safely generating entropy itself. Besides that, the<crypt.h>header of the library already definesCRYPT_GENSALT_OUTPUT_SIZE.