added builtin list::reverse for YCP list

VERSION

@@ -1 +1 @@
-2.23.3
+2.23.4

libycp/src/YCPBuiltinList.cc

@@ -1173,7 +1173,7 @@ l_swaplist (const YCPList &v, YCPInteger &i1, YCPInteger &i2){
     /**
      * @builtin list::swap
      * @id list.swap
-     * @short Creates new list with swaped elemetns at offset i1 and i2.
+     * @short Creates new list with swaped elements at offset i1 and i2.
      * @param list<flex1> v list
      * @param integer i1 index of first element
      * @param integer i2 index of second element
@@ -1218,6 +1218,32 @@ l_swaplist (const YCPList &v, YCPInteger &i1, YCPInteger &i2){
     return ret;
 }
 
+static YCPValue
+l_reverselist (const YCPList &v){
+    /**
+     * @builtin list::reverse
+     * @id list.reverse
+     * @short Creates new list with reversed order of elements.
+     * @param list<flex1> v list
+     * @return New list. Changed if offset is correct, otherwise return unchanged list 
+     *
+     * @description
+     * Creates new list with reversed order of elements. Return nil if list is nil. 
+     *
+     * @usage list::reverse ([0,1,2,3]) -> [3,2,1,0]
+     * @usage list::reverse ([]) -> []
+     */
+    if (v.isNull ())
+    {
+	ycp2error ("Cannot reverse 'nil' list");
+	return YCPNull ();
+    }
+
+    YCPList ret = v;
+    ret->reverse();
+    return ret;
+}
+
 static YCPValue
 l_tolist (const YCPValue &v)
 {
@@ -1289,6 +1315,7 @@ YCPBuiltinList::YCPBuiltinList ()
 	{ "reduce",	"flex1 (variable <flex1>, variable <flex1>, const list <flex1>, const block <flex1>)",  (void *)l_reduce1, DECL_LOOP|DECL_SYMBOL|DECL_FLEX, ETCf },
 	{ "reduce",	"flex1 (variable <flex1>, variable <flex2>, const flex1, const list <flex2>, const block <flex1>)", (void *)l_reduce2, DECL_LOOP|DECL_SYMBOL|DECL_FLEX, ETCf },
 	{ "swap",	"list <flex> (const list <flex>, const integer, const integer)",			(void *)l_swaplist,	DECL_FLEX, ETCf },
+	{ "reverse",	"list <flex> (const list <flex>)",	(void *)l_reverselist,	DECL_FLEX, ETCf },
 	{ NULL, NULL, NULL, ETC }
     };
 

libycp/src/YCPList.cc

@@ -97,6 +97,12 @@ YCPListRep::remove (const int n)
 }
 
 
+void
+YCPListRep::reverse()
+{
+    std::reverse(elements.begin(), elements.end());
+}
+
 void
 YCPListRep::swap (int x, int y)
 {

libycp/src/include/ycp/YCPList.h

@@ -111,6 +111,12 @@ class YCPListRep : public YCPValueRep
      */
     void remove(const int n);
 
+    /**
+     * Reverses the elements in the list. This function
+     * changes the list.
+     */
+    void reverse();
+
     /**
      * Exchanges the elements at the indices x and y. This function
      * changes the list.
@@ -248,6 +254,7 @@ class YCPList : public YCPValue
     void push_back(const YCPValue& value) { ELEMENT->push_back(value); }
     void set(const int n, const YCPValue& value) { ELEMENT->set (n, value); }
     void remove(const int n) { ELEMENT->remove (n); }
+    void reverse() { ELEMENT->reverse(); }
     void swap(int x, int y) { ELEMENT->swap (x, y); }
     bool contains (const YCPValue& value) const { return CONST_ELEMENT->contains (value); }
     void sortlist() { ELEMENT->sortlist (); }

libycp/testsuite/tests/builtin/revlist.err

@@ -0,0 +1,17 @@
+Parsed:
+----------------------------------------------------------------------
+list::reverse ([0, 1, 2, 3])
+----------------------------------------------------------------------
+Parsed:
+----------------------------------------------------------------------
+list::reverse ([0])
+----------------------------------------------------------------------
+Parsed:
+----------------------------------------------------------------------
+list::reverse ([])
+----------------------------------------------------------------------
+Parsed:
+----------------------------------------------------------------------
+list::reverse (nil)
+----------------------------------------------------------------------
+[Interpreter] tests/builtin/revlist.ycp:16 Argument (nil) to reverse(...) is nil

libycp/testsuite/tests/builtin/revlist.out

@@ -0,0 +1,4 @@
+([3, 2, 1, 0])
+([0])
+([])
+(nil)

libycp/testsuite/tests/builtin/revlist.ycp

@@ -0,0 +1,16 @@
+# ---------------------------------------------------------
+#
+#  Filename:    revlist.ycp
+#
+#  Purpose:     test cases for YCP list::reverse builtin
+#
+#  Creator:     fehr@suse.de
+#
+#  Maintainer:  fehr@suse.de
+#
+# --------------------------------------------------------
+
+(list::reverse([0,1,2,3]))
+(list::reverse([0]))
+(list::reverse([]))
+(list::reverse(nil))

package/yast2-core.changes

@@ -1,3 +1,9 @@
+-------------------------------------------------------------------
+Wed Jun 20 15:41:57 CEST 2012 - fehr@suse.de
+
+- 2.23.4
+- added builtin list::reverse for YCP list
+
 -------------------------------------------------------------------
 Tue Jun 19 07:42:53 UTC 2012 - mfilka@suse.com