Fixed another batch of compilation warnings. #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: 'log_messages' defined but not used [-Wunused-variable]
warning: 'void do_log_syslog(const char*)' defined but not used [-Wunused-function]
|
looks good, but I propose to merge it after SLE12 as it do not bring nothing interesting in functionality |
|
I understand that you hesitate to merge this into RC2 before I disappear into the woods. But skipping SLE is too much; when I return I will convince you it is safe :) |
|
@jreidinger can we resolve this one? It takes only 10 minutes. I am willing to retract objectionable commits but would like to keep the obvious ones. |
warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]
It was a TODO that went unfixed for 10+ years. Give way to real comipler warnings.
The method has been used in the YCP parser for the type of the container[indices]:default construct, so we are pretty sure it was in fact finished and complete, for al practical purposes. Give way to real compiler warnings.
|
|
OK, LGTM |
mvidner
added a commit
that referenced
this pull request
Aug 26, 2014
Fixed another batch of compilation warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to do only the "obvious" warnings. See commit messages for explanations.