Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging fix - move language_dbus.rb file (bsc#1069119) #152

Merged
merged 3 commits into from
Nov 24, 2017

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Nov 24, 2017

See bug https://bugzilla.suse.com/show_bug.cgi?id=1069119

  • The y2country/language_dbus.rb file packaged in yast2-country is required by Language.rb which is for some reason located in yast2-country-data. If the package depends only on yast2-country-data then Yast.import "Language" fails because the y2country/language_dbus.rb file is missing.

  • I have additionally added a nil check, I do not know why but in my TW system it failed with nil error. Just make sure it won't happen in some corner cases.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 20.256% when pulling c8370a3 on packaging_fix into 4c4958d on master.

Copy link
Member

@schubi2 schubi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit 90fa82f into master Nov 24, 2017
@lslezak lslezak deleted the packaging_fix branch November 24, 2017 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants