Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard rewrite: select current layout on startup #196

Closed
wants to merge 125 commits into from
Closed

Keyboard rewrite: select current layout on startup #196

wants to merge 125 commits into from

Conversation

jyeray
Copy link

@jyeray jyeray commented Nov 22, 2018

This is for openSUSE/mentoring#79, "Re-implement the YaST keyboard management in a proper object oriented way".

In this pull request the current keyboard layout in the system is selected when start the module.

@jyeray
Basic interface to select keyboard layout
bd2ba9e
@jyeray
load keyboard layouts returns a lists of keyboard layouts
c4e2d6f
@jyeray
add test helper for keyboard rewrite tests
8d89b7b
@jyeray
extract explanatory method to test_helper
1fc2b83
@jyeray
Layout selector load keyboard layouts
ab14abe
@jyeray
move method to test_helper
f2683eb
@jyeray
create keyboard layout class
5a4f068
@jyeray
load virtual console layouts instead xorg ones
f4663b1
@jyeray
initialize the layout description
a367d5c
@jyeray
does not return layouts that not have description
490a5d4
@jyeray
rename test
c759441
@jyeray
Show description in layout list
f5ccc28
@jyeray
Reorganize in another folder
b95aefc
@jyeray
Fix some rubocop offenses
3935d55
@jyeray
Merge files
0599b60
@jyeray
set the console layout
c883168
@jyeray
accept_handler closes the dialog
602d8cd
@jyeray
accept_handler change the keymap to the selected layout
39b6906
@jyeray
fix test
017fdb0
@jyeray
Rename dialog module to ajust to YaST convention
1a96ff6
@jyeray
add client
5342771
@jyeray
refactor: rename method
6af78ad
@jyeray
extract helpers module
8145422
@jyeray
fix can not import files
fe64bac
@jyeray
refactor: avoid to use block code in a .map
374937e
@jyeray
fix typo error in test description
1156f51
@jyeray
inject keyboard layouts instead retrive in the dialog
d3c10f9
@jyeray
inject keyboard layouts in client
1a60678
@jyeray
Merge branch 'keyboard_rewrite' into change_keyboard_layout
07ded50
@jyeray
fix tests
6947786
jyeray added 27 commits May 17, 2018 19:55
@jyeray
LayoutSelector now uses SystemdStrategy insted of KeyboardLayout
b6ae951
@jyeray
Keyboard client now uses SystemdStrategy insted of KeyboardLayout
b80fad5
@jyeray
Remove unused methods
3f50e6a
@jyeray
Create instance methods for SystemdStrategy
d4cae32
@jyeray
remove unnecessary require
866a1e5
@jyeray
Fix requires
428eeb5
@jyeray
Inject strategy to LayoutSelector class
3d8c145
@jyeray
Refactor: convert class methods into instace methods
c4940e0
@jyeray
Adjust require
4f2beda
@jyeray
Update SystemdStrategy spec describes
65eb585
@jyeray
Retrieve keyboard layouts from strategy
737e695
@jyeray
lists the keyboard layouts
0602af9
@jyeray
LayoutSelector only receive an strategy
00d5191
@jyeray
Add class top-documentation to SystemdStrategy
bceacc1
@jyeray
Apologize to rubocop
4dd9751
@jyeray
Improve test: lists the keyboard layouts
af9d949
@jyeray
Create items to show layout in the list
94ad3ac
@jyeray
Select the current layout in the list
0210b7e
@jyeray
refactor: rename method
e20046f
@jyeray
Use layout code as item id instead of description
7464a15
@jyeray
Fix tests: now QueryWidget to :layout_list returns the layout code
6346eb5
@jyeray
Merge branch 'master' into keyboard_rewrite
2688f68
@jyeray
Merge branch 'keyboard_rewrite' into change_keyboard_layout
ecf865a
@jyeray
Merge branch 'change_keyboard_layout' into test_layout
25b3a9d
@jyeray
Merge branch 'test_layout' into 4_add_rubocop
73f84c2
@jyeray
Merge branch '4_add_rubocop' into 5_extract_repository
caf2ce3
@jyeray
Merge branch '5_extract_repository' into 6_select_current_layout_on_s…
6e325c3 
…tartup
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 21.684% when pulling 6e325c3 on jyeray:6_select_current_layout_on_startup into c5127ad on yast:master.

@schubi2
Copy link
Member

schubi2 commented Oct 23, 2019

We have taken this code as a base for refactoring the complete keyboard module:
https://github.com/yast/yast-country/pull/225/files
So Joaquín, thank you for your great work ! It has helped us a lot !!!!

@schubi2 schubi2 closed this Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jyeray @coveralls @schubi2