Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard rewrite: fix error setting x11 keymap #198

Closed
wants to merge 165 commits into from

Conversation

jyeray
Copy link

@jyeray jyeray commented Nov 22, 2018

This is for openSUSE/mentoring#79, "Re-implement the YaST keyboard management in a proper object oriented way".

An error while setting the x11 keymap is fixed. It happened because the parameters passed to setxkbmap command was invalid in some cases.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 22.006% when pulling 1dacd48 on jyeray:9_fix_error_setting_x11_keymap into c5127ad on yast:master.

@schubi2
Copy link
Member

schubi2 commented Oct 23, 2019

We have taken this code as a base for refactoring the complete keyboard module:
https://github.com/yast/yast-country/pull/225/files
So Joaquín, thank you for your great work ! It has helped us a lot !!!!

@schubi2 schubi2 closed this Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants