Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using obsolete XVersion #205

Merged
merged 2 commits into from
Aug 7, 2019
Merged

Stop using obsolete XVersion #205

merged 2 commits into from
Aug 7, 2019

Conversation

mvidner
Copy link
Member

@mvidner mvidner commented Mar 5, 2019

It was useful in 2006 when X.org 6 and X.org 7 had different places for files

Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Escaping?

keyboard/src/modules/Keyboard.rb Show resolved Hide resolved
Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

It was useful in 2006 when X.org 6 and X.org 7 had different places for files
@mvidner mvidner marked this pull request as ready for review August 7, 2019 08:26
@mvidner mvidner merged commit aa419a1 into master Aug 7, 2019
@yast-bot
Copy link
Contributor

yast-bot commented Aug 7, 2019

❌ Public Jenkins job #28 failed

@yast-bot
Copy link
Contributor

yast-bot commented Aug 7, 2019

❌ Internal Jenkins job #5 failed

@mvidner
Copy link
Member Author

mvidner commented Aug 7, 2019

Ugh, a gh reference is not enough for Jenkins. I've created https://bugzilla.suse.com/show_bug.cgi?id=1144627 and will fill that in

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 21.32% when pulling 8f5b518 on no-xversion into 4fb3fe6 on master.

@mvidner mvidner mentioned this pull request Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants