experimentaly enable new rubocop #321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying changes from new rubocop. Review per commit to distinguish what was done manually and what automatic.
see also yast/yast-yast2#1298
Also this is experiment how it will look in module without rubocop.
So initial result for this quite old yast code is
56 files inspected, 1461 offenses detected, 1127 offenses autocorrectableand when correcting with
-ait leads to two infinitive loop that I need manually fixed.Also in this case we hit rubocop/rubocop#11828 when autocorrecting languages big hash, so I need manually fix it.