Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes in the tumbleweed mappings (bsc#942899 and bsc#942896) #61

Merged
merged 4 commits into from
Jun 20, 2016

Conversation

ancorgs
Copy link
Contributor

@ancorgs ancorgs commented Oct 28, 2015

No description provided.

@jreidinger
Copy link
Member

LGTM

@lnussel
Copy link

lnussel commented Jan 26, 2016

so who is in charge to press the merge button here?

@ancorgs
Copy link
Contributor Author

ancorgs commented Jan 26, 2016

@lnussel It would be me. But I'm waiting for the (intermittent) discussion at https://bugzilla.suse.com/show_bug.cgi?id=942896 Like, for example, response from systemd maintainers. Tests from Mindaugas suggest this PR could not be that great, but we need to research the reasons.

Regarding the Ukranian keyboard, the fix is already merged by another PR.

@lnussel
Copy link

lnussel commented Jun 16, 2016

so?

lnussel added a commit to os-autoinst/os-autoinst-needles-opensuse that referenced this pull request Jun 17, 2016
@ancorgs
Copy link
Contributor Author

ancorgs commented Jun 17, 2016

Today I will finally have time to go over the bug report again and analyze the new comments. Stay tuned.

@ancorgs
Copy link
Contributor Author

ancorgs commented Jun 17, 2016

See https://bugzilla.opensuse.org/show_bug.cgi?id=942896#c52 If nobody has opposed, I will merge this pull request on Monday.

@ancorgs
Copy link
Contributor Author

ancorgs commented Jun 20, 2016

Nobody opposed. Merge time!

@ancorgs ancorgs merged commit 82cb36e into yast:master Jun 20, 2016
ancorgs added a commit to ancorgs/yast-country that referenced this pull request Aug 10, 2016
kobliha added a commit that referenced this pull request Aug 10, 2016
Changelog entry missing in pull request #61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants