-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y2logs analyzer #149
base: master
Are you sure you want to change the base?
Y2logs analyzer #149
Conversation
elsif RAR_REGEXPS.any? { |r| archive =~ r } | ||
Cheetah.run("unrar", "x", archive, file) | ||
else | ||
raise "Should not happen :)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not be that sure 😉
ytools/y2tool/analyze_logs
Outdated
result | ||
ensure | ||
if temp_dir | ||
Cheetah.run("rm", "-rf", file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not FileUtils.rm_rf
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, original intention was logging, but probably not so important. So FileUtils can be used.
Do you feel this still needed? If not, I'd close it and maybe move the idea to the new tool for Agama (internal link) |
No description provided.