Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sle15sp3 boo1199396 #168

Open
wants to merge 2 commits into
base: SLE-15-SP3
Choose a base branch
from

Conversation

noelpower
Copy link

Problem

  • y2makepot doesn't scan python source files for text that needs to be translated

Signed-off-by: Noel Power <noel.power@suse.com>
Signed-off-by: Noel Power <noel.power@suse.com>
@lslezak
Copy link
Member

lslezak commented Jul 11, 2022

Just for the record, a minimal Python file for verifying the functionality (test.py):

textdomain("test")
_("test")

Then y2tool y2makepot generates test.pot with the extracted string, it works fine.

Question

But does it make sense to backport the fix to SLE15-SP3/Leap-15.3? AFAIK we do not have any Python translations there...
And even if we had translating the new texts would be very likely not possible...

I think this should only go to master, as you originally did in PR #167.

@dgdavid
Copy link
Member

dgdavid commented Jul 25, 2022

@noelpower, @lslezak friendly ping guys :) Should we go ahead with this PR or close it instead?

@lslezak
Copy link
Member

lslezak commented Jul 25, 2022

The PR is OK, I'd just change the target to master...

@dgdavid
Copy link
Member

dgdavid commented Jul 26, 2022

@noelpower Do you mind changing the target to master?

@noelpower
Copy link
Author

@lslezak @dgdavid I missed the initial response here (start of July) and have been on vacation for the last week or so, in the middle of catchup now so I am sorry for the delay in responding.
IIRC the only reason I closed #167 changed the target to 15-sp3 (with the intention for merge forward to the more recent branches and master if this pull was approved) was just to cover the outside chance we might introduce some ui because the most recent sle15 versions sle15-sp3/sp4 share the same samba version (and the most likely source of some python ui text would be in some samba module :-))
Is it true that if this change went into sp3 we would not be able to get text translated if for some reason we needed to add some .py strings ?

Note: I am not desperate to get this into sp3 (then sp4 and master), if it makes more sense then just putting it to master is ok with me (and I can close this and reopen #167) So if the consensus is still that master makes more sense I'll retarget, what do you all think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants