Removed testsuite

Since the module is written in Perl, it's not possible to substitute the removed tests with RSpec equivalents. We decided to just drop them.
yast · Feb 7, 2020 · 4bc6d77 · 4bc6d77
1 parent 50ce9b8
commit 4bc6d77
Show file tree

Hide file tree

Showing 13 changed files with 5 additions and 352 deletions.
diff --git a/.gitignore b/.gitignore
@@ -20,17 +20,9 @@ autom4te.cache
 Makefile.am.common
 *.ami
 doc/autodocs/
-/testsuite/config/
-/testsuite/run/
 doc/autodocs/.yardoc/
 doc/autodocs/Yast/
 doc/autodocs/css/
 doc/autodocs/js/
-testsuite/*.exp
-testsuite/*.err.*
-testsuite/tmp.out.*
-testsuite/*.log
-testsuite/yast2-dhcp-server.sum
-testsuite/yast2-dhcp-server.test/
 .yardoc
 /coverage
diff --git a/package/yast2-dhcp-server.changes b/package/yast2-dhcp-server.changes
@@ -1,3 +1,8 @@
+-------------------------------------------------------------------
+Fri Feb  7 08:21:50 UTC 2020 - Ancor Gonzalez Sosa <ancor@suse.com>
+
+- Removed the testsuite
+
 -------------------------------------------------------------------
 Mon Jul  1 16:18:15 UTC 2019 - Knut Anderssen <kanderssen@suse.com>
 

diff --git a/package/yast2-dhcp-server.spec b/package/yast2-dhcp-server.spec
@@ -37,7 +37,6 @@ BuildRequires:  popt-devel
 BuildRequires:  sgml-skel
 BuildRequires:  update-desktop-files
 BuildRequires:  yast2-perl-bindings
-BuildRequires:  yast2-testsuite
 BuildRequires:  yast2-dns-server
 BuildRequires:  yast2-devtools >= 4.2.2
 # Fix old testsuite bind package absence mocks

diff --git a/src/modules/DhcpServer.pm b/src/modules/DhcpServer.pm
@@ -220,12 +220,6 @@ sub InitTSIGKeys {
 
 sub AdaptDDNS {
     my $self = shift;
-
-    # FIXME temporary hack because of testsuite
-    if (Mode->test ())
-    {
-	return 1;
-    }
     my @directives = @{$self->GetEntryDirectives ("", "") || []};
 
     @directives = grep {

diff --git a/testsuite/.cvsignore b/testsuite/.cvsignore
diff --git a/testsuite/Makefile.am b/testsuite/Makefile.am
diff --git a/testsuite/tests/.cvsignore b/testsuite/tests/.cvsignore
diff --git a/testsuite/tests/Read.err b/testsuite/tests/Read.err
diff --git a/testsuite/tests/Read.out b/testsuite/tests/Read.out
diff --git a/testsuite/tests/Read.rb b/testsuite/tests/Read.rb
diff --git a/testsuite/tests/Write.err b/testsuite/tests/Write.err
diff --git a/testsuite/tests/Write.out b/testsuite/tests/Write.out
diff --git a/testsuite/tests/Write.rb b/testsuite/tests/Write.rb