Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker at Travis, service widget initialization fix #19

Merged
merged 3 commits into from
Jan 18, 2017
Merged

Docker at Travis, service widget initialization fix #19

merged 3 commits into from
Jan 18, 2017

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Jan 18, 2017

  • Yet another issue with the silently failed import was revealed (and fixed here).

@lslezak
Use Docker at Travis
bbc1d92
@lslezak
Fix the failing imports
d2c3a86 
Make the service widget initialization lazy as it requires
the "dhcp-server" package which is installed later in the workflow.
@lslezak
Changes
14de31f 
- 3.2.2
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 20.417% when pulling 14de31f on docker_at_travis into 0d7d068 on master.

jreidinger
jreidinger approved these changes Jan 18, 2017
View reviewed changes
Copy link
Member

@jreidinger jreidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it works, let change this, but really disgusting original

@lslezak lslezak merged commit c161a72 into master Jan 18, 2017
@lslezak lslezak deleted the docker_at_travis branch January 18, 2017 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreidinger jreidinger jreidinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lslezak @coveralls @jreidinger