Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed old testsuite not depending on named service and bind package in test mode. #45

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Fixed old testsuite not depending on named service and bind package in test mode. #45

merged 1 commit into from
Jul 1, 2019

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Jul 1, 2019

Problem

  • Failing old testsuite in yast2-dhcp-server
  • It depends on bind rpm installed.

Fix

  • Do not depend on the package installed at all in Mode.test()
  • 4.2.1

@coveralls
Copy link

Coverage Status

Coverage remained the same at 16.993% when pulling 24a34fc on fix_oldtestsuite into 1633830 on master.

@teclator teclator merged commit 7c6daf4 into master Jul 1, 2019
@teclator teclator deleted the fix_oldtestsuite branch July 1, 2019 16:37
@yast-bot
Copy link
Contributor

yast-bot commented Jul 1, 2019

✔️ Public Jenkins job #14 successfully finished
✔️ Created OBS submit request #712899

@yast-bot
Copy link
Contributor

yast-bot commented Jul 1, 2019

❌ Internal Jenkins job #4 failed

@yast-bot
Copy link
Contributor

yast-bot commented Jul 9, 2019

✔️ Internal Jenkins job #5 successfully finished
✔️ Created IBS submit request #196341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teclator @coveralls @yast-bot @imobachgs