Fix check of 'set' and 'key' options #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teclator
force-pushed
the
fix_options_check_sp4
branch
from
5ba9ce0
to
3895fcd
Compare
teclator
added a commit
that referenced
this pull request
Mar 27, 2020
Fix check of 'set' and 'key' options
teclator
added a commit
that referenced
this pull request
Mar 27, 2020
Merge pull request #47 from yast/fix_options_check_sp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the 'set' option is used, the options given are checked in order to determine if the mandatory parameters were given or not. The problem is that the check is checking the wrong options variable.
Solution
Use the correct options variable.