No token ring anymore #52
Conversation
| @@ -124,7 +124,7 @@ def initialize_dhcp_server_commandline(include_target) | |||
| "The hardware type of the host with a fixed address" | |||
| ), | |||
| "type" => "enum", | |||
| "typespec" => ["ethernet", "token-ring"] | |||
| "typespec" => ["ethernet"] | |||
There was a problem hiding this comment.
does this make sense at all? maybe for backward compatibility?
There was a problem hiding this comment.
I was not sure. I've kept it for compatibility reasons only. AFAIK it is not mandatory anyway.
There was a problem hiding this comment.
so at least please add comment that it is just for backward compatibility and maybe after string freeze we can add to help text that it is now noop.
src/include/dhcp-server/dialogs2.rb
Outdated
| _("Token Ring") | ||
| opts.fetch("ip", ""), | ||
| opts.fetch("hardware", ""), | ||
| _("Ethernet") |
There was a problem hiding this comment.
maybe we can remove this column in table?
There was a problem hiding this comment.
Another place where I was not sure. I'll remove it.
src/include/dhcp-server/dialogs2.rb
Outdated
| @@ -1805,19 +1777,18 @@ def CheckMacAddrFormat | |||
| addr_type = Convert.to_string( | |||
| UI.QueryWidget(Id("network_type"), :CurrentButton) | |||
There was a problem hiding this comment.
does this widget still exists?
|
screenshots are in trello ... I'll add it even here. |
|
✔️ Public Jenkins job #17 successfully finished |
|
✔️ Internal Jenkins job #8 successfully finished |
bsc#1167474