Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No token ring anymore #52

Merged
merged 5 commits into from
Apr 6, 2020
Merged

No token ring anymore #52

merged 5 commits into from
Apr 6, 2020

Conversation

mchf
Copy link
Member

@mchf mchf commented Apr 5, 2020

bsc#1167474

@coveralls
Copy link

coveralls commented Apr 5, 2020

Coverage Status

Coverage increased (+0.04%) to 17.029% when pulling e2ff8bb on mchf:no_token_ring into 2717e61 on yast:master.

@@ -124,7 +124,7 @@ def initialize_dhcp_server_commandline(include_target)
"The hardware type of the host with a fixed address"
),
"type" => "enum",
"typespec" => ["ethernet", "token-ring"]
"typespec" => ["ethernet"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this make sense at all? maybe for backward compatibility?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not sure. I've kept it for compatibility reasons only. AFAIK it is not mandatory anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so at least please add comment that it is just for backward compatibility and maybe after string freeze we can add to help text that it is now noop.

_("Token Ring")
opts.fetch("ip", ""),
opts.fetch("hardware", ""),
_("Ethernet")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can remove this column in table?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another place where I was not sure. I'll remove it.

@@ -1805,19 +1777,18 @@ def CheckMacAddrFormat
addr_type = Convert.to_string(
UI.QueryWidget(Id("network_type"), :CurrentButton)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this widget still exists?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, it escaped ... will fix

Copy link
Member

@jreidinger jreidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe some screenshots would be nice.

@mchf
Copy link
Member Author

mchf commented Apr 6, 2020

screenshots are in trello ... I'll add it even here.

@mchf mchf merged commit 4014407 into yast:master Apr 6, 2020
@mchf mchf deleted the no_token_ring branch April 6, 2020 07:25
@yast-bot
Copy link
Contributor

yast-bot commented Apr 6, 2020

✔️ Public Jenkins job #17 successfully finished
✔️ Created OBS submit request #791656

@yast-bot
Copy link
Contributor

yast-bot commented Apr 6, 2020

✔️ Internal Jenkins job #8 successfully finished
✔️ Created IBS submit request #215398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants