IsDNSZoneMaintained returns inverted value

[obel1x]

IsDNSZoneMaintained returns inverted value, leading to not working "Synchronise DNS-Server"

[coveralls]

Coverage increased (+0.1%) to 18.002% when pulling 9c9b4d6 on obel1x:master into 20c9454 on yast:master.

[dgdavid]

@obel1x thanks a ton for your contribution! At first glance, it looks reasonable to me.

But in order to get it merged, we need to update the version and changelog (see https://yastgithubio.readthedocs.io/en/latest/contributing/#code-changes) and ideally add a small unit test for touched code in https://github.com/yast/yast-dhcp-server/blob/master/test/dialog_test.rb.

We can proceed as you want: you try to do it by yourself and we review it, or I can help with it for moving it on if you're busy.

[obel1x]

great, thanks! i have had a quick look at those unit tests. ruby looks like a beautiful language, but as i am not used to it and also would not know how the test should look processual, i think it should be better done by you.

Also currently i do not have a local copy with rake and osc installed, this was done on github directly. So please can you also do the version changes and changelogs?

Maybe some time i will get back to this and then doing it right, currently i am focussing on other suse related tasks.
Best rgs, daniel

[dgdavid]

... i think it should be better done by you.

Also currently i do not have a local copy with rake and osc installed, this was done on github directly. So please can you also do the version changes and changelogs?

Sure, no problem. Added to my to-do list :)

Thanks

[dgdavid]

Merged! Thanks a lot @obel1x!

[yast-bot]

✔️ Internal Jenkins job #20 successfully finished
✔️ Created IBS submit request #262158

[yast-bot]

✔️ Public Jenkins job #29 successfully finished
✔️ Created OBS submit request #946188