Merge d299306 into 275fecf

yast · Sep 20, 2019 · d40f10d · d40f10d
2 parents 275fecf + d299306
commit d40f10d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 10 deletions.
diff --git a/package/yast2-dns-server.changes b/package/yast2-dns-server.changes
@@ -1,3 +1,10 @@
+-------------------------------------------------------------------
+Fri Sep 20 14:12:10 UTC 2019 - Knut Anderssen <kanderssen@suse.com>
+
+- Do not modify the service when finishing the wizard dialog as
+  the configuration has not been written yet. (bsc#1123985)
+- 4.1.3
+
 -------------------------------------------------------------------
 Sun Nov 25 02:10:40 UTC 2018 - Stasiek Michalski <hellcp@mailbox.org>
 

diff --git a/package/yast2-dns-server.spec b/package/yast2-dns-server.spec
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-dns-server
-Version:        4.1.2
+Version:        4.1.3
 Release:        0
 Url:            https://github.com/yast/yast-dns-server
 

diff --git a/src/include/dns-server/dialog-installwizard.rb b/src/include/dns-server/dialog-installwizard.rb
@@ -28,14 +28,6 @@ def initialize_dns_server_dialog_installwizard(include_target)
       Yast.import "CWMFirewallInterfaces"
     end
 
-    # Writes settings and saves the service
-    #
-    # @return [Boolean] true if service is saved successfully; false otherwise
-    def write_dns_settings
-      service_widget.store
-      service.save
-    end
-
     def runInstallWizardForwardersDialog
       caption =
         # Dialog caption (before a colon)
@@ -261,7 +253,7 @@ def runInstallWizardFinishDialog
       end
 
       if ret == :next || ret == :expert
-        write_dns_settings
+        service_widget.store
 
         CWMFirewallInterfaces.OpenFirewallStore(firewall_widget, "", event)
       end