Various fixes in named.conf #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a better test case for the whitespace part
json is as currently parsed, that is, wrong
mvidner
changed the title
pod2html -o doc.html src/modules/DnsData.pm
mvidner
changed the title
| # @return [Array<String>] | ||
| def current_zone_allow_transfer | ||
| items = [] | ||
| @current_zone.fetch("options", []).each do |m| |
There was a problem hiding this comment.
I wasn't able to find explicit definition / initialization of @current_zone. Is it an intention?
There was a problem hiding this comment.
Ah, good point. It is in DnsServerUi.rb which is an "envelope" module defining the variables and including the parts to work on them, dialog-masterzone.rb is one of them.
|
besides that it looks fine for me |
|
It looks also good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bsc#976643 (L3)
https://trello.com/c/wSXpTL68
It's a follow-up for the fix for trailing whitespace (#54).
Fixed
{would mean the rest of the file was misparsed (interpreted it as a beginning of a section)allow-transfer, shown in zone editation Basics tab as "Enable zone transport", unnamed addresses (that do not have anacldeclaration) would be droppedTo Do:
addition of a zone record was lost(just a misunderstanding in BZ)