improve edit dialog

yast · Jun 20, 2013 · 5bdc39e · 5bdc39e
1 parent 380f87e
commit 5bdc39e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/FcoeClient.ycp b/src/FcoeClient.ycp
@@ -362,9 +362,9 @@ global map<string, list> GetVlanInterfaces( list net_devices )
 
     foreach ( string dev, (list<string>)net_devices, {
 	    foreach( string line, (list<string>)lines, {
-		    // check whether there is a line for the given interface, e.g.
+		    // Check whether there is a line for the given interface, e.g.
 		    // eth3            | 200  | 00:0d:ec:a2:ef:00\n
-		    // and get VLAN channel from second columns.
+		    // Get VLAN channel from second column and FCF MAC from third.
                     line = deletechars( line, " \t" );
                     list<string> columns = splitstring( line, "|" );
 		    if ( columns[0]:"" == dev )

diff --git a/src/complex.ycp b/src/complex.ycp
@@ -256,7 +256,8 @@ void InitEditDialog( string id )
 	UI::ChangeWidget( `id(`auto), `Enabled, false );	
     }
     // headline of the edit dialog - configuration of values for a certain network interface
-    UI::ChangeWidget( `id(`heading), `Value, sformat( _("Configuration of Interface %1"), card["fcoe_vlan"]:"" ) );
+    UI::ChangeWidget( `id(`heading), `Value, sformat( _("Configuration of VLAN interface %1 on %2"),
+                                                      card["vlan_interface"]:"", card["dev_name"]:"" ) );
 }
 
 /**

diff --git a/src/dialogs.ycp b/src/dialogs.ycp
@@ -67,9 +67,10 @@ term EditDialogContents()
 {
     return `VBox(
 		 `VStretch(),
+                 `VSpacing(1),
 		 // heading is replaced later (InitEditDialog)
 		 `Label( `id(`heading), ("Configuration of Interface .......................") ),
-		 `VSpacing(2),
+		 `VSpacing(1),
 		 `HBox (
 			`HStretch(),
 			`Frame( (""),