Sp2 merge #140
Merged
Sp2 merge #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teclator
reviewed
Oct 19, 2020
Rakefile
Outdated
| @@ -1,5 +1,7 @@ | |||
| require "yast/rake" | |||
|
|
|||
| Yast::Tasks.submit_to :sle15sp2 | |||
There was a problem hiding this comment.
this should be removed or revoked the same as the Dockerfile
teclator
reviewed
Oct 19, 2020
| @@ -81,6 +81,9 @@ def configure_firewall | |||
| # Convenience method to enable / disable the firewalld service depending | |||
| # on the proposal settings | |||
| def configure_firewall_service | |||
| # do not run in autoyast as it is done in second stage (bsc#1177778) | |||
| return if Yast::Mode.auto | |||
There was a problem hiding this comment.
As commented in #139 it probably should not be done in master as it should be already handled.
There was a problem hiding this comment.
There was a problem hiding this comment.
After checked it is ok to be added.
This reverts commit affba0a.
|
✔️ Internal Jenkins job #16 successfully finished |
|
✔️ Public Jenkins job #39 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge of #139
regarding moving firewall config to first stage, I would let it to own PBI.