Improve allowed services tab #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
force-pushed
the
improve-allowed-services-tab
branch
from
8243210
to
b937c33
Compare
imobachgs
force-pushed
the
improve-allowed-services-tab
branch
from
51ed8a1
to
b036de7
Compare
imobachgs
changed the title
mvidner
reviewed
Sep 12, 2018
| _("Allowed Services") | ||
| end | ||
|
|
||
| # @macro seeCustomWidget | ||
| def contents | ||
| return @contents if @contents | ||
|
|
||
| VBox( |
| PushButton( | ||
| Id(:remove), | ||
| Opt(:hstretch), | ||
| "#{Yast::UI.Glyph} " + _("<- Remove") |
There was a problem hiding this comment.
Glyph without arguments is wrong, also below.
imobachgs
force-pushed
the
improve-allowed-services-tab
branch
from
544ca70
to
2c862d6
Compare
mvidner
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Allowed Services tab and adds some unit tests.