Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate the Ports tab input #80

Merged
merged 1 commit into from Sep 19, 2018
Merged

Validate the Ports tab input #80

merged 1 commit into from Sep 19, 2018

Conversation

mvidner
Copy link
Member

@mvidner mvidner commented Sep 17, 2018

No description provided.

@coveralls
Copy link

coveralls commented Sep 17, 2018 •
edited

Coverage Status

Coverage increased (+0.2%) to 12.289% when pulling 1dd03bf on validate-ports into 894d95f on new-ui.

imobachgs
imobachgs reviewed Sep 19, 2018
View reviewed changes
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Would you consider adding a test for the #validate method?

src/lib/y2firewall/widgets/pages/zone.rb Outdated

def validate
by_proto = values
by_proto.each do |sym, ranges|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np: Perhaps I would change sym by proto to make it clear.

@mvidner mvidner merged commit d67c998 into new-ui Sep 19, 2018
@mvidner mvidner deleted the validate-ports branch September 19, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imobachgs imobachgs imobachgs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvidner @coveralls @imobachgs