Allow to change the default zone #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
force-pushed
the
set-default-zone
branch
from
82dcccd
to
3634e8b
Compare
imobachgs
force-pushed
the
set-default-zone
branch
4 times, most recently
from
53e7039
to
ff1cf23
Compare
imobachgs
force-pushed
the
set-default-zone
branch
from
ff1cf23
to
09afc83
Compare
teclator
reviewed
Sep 20, 2018
| end | ||
|
|
||
| # @see CWM::Table#header | ||
| def header | ||
| [ | ||
| _("Name"), | ||
| _("Interfaces") | ||
| _("Interfaces"), | ||
| _("Default") |
There was a problem hiding this comment.
I'm not sure about having an extra column for it, but probably that is something for Ken, I would maybe prefer something like public (default)
There was a problem hiding this comment.
We have something similar in the repository list, but it is a slightly different case. But we might append a "(default)" string if preferred.
|
LGTM once travis is fine with the rdoc check 😉 |
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to change the Firewalld's default zone.