Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove completely old susefirewall dialogs and modules #90

Merged
merged 2 commits into from Nov 22, 2018
Merged

Remove completely old susefirewall dialogs and modules #90

merged 2 commits into from Nov 22, 2018

Conversation

teclator
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Sep 21, 2018 •
edited

Coverage Status

Coverage increased (+70.3%) to 88.2% when pulling 91dce6c on remove_susefirewall into 0c2af9c on master.

@teclator
Copy link
Contributor Author

@imobachgs @mvidner It seems it is not used in any other place, so we could remove it already in SLE-15-GA, and remove the rest (yast2 and yast2-network modules) of the old SuSEFirewall2 code only from the master branch

@imobachgs
Copy link
Contributor

If it is not used, I am fine with removing it. But I am not sure if it is a good thing for a MU.

@teclator
Copy link
Contributor Author

teclator commented Sep 21, 2018 •
edited

Yep, that was my main doubt and still it is 😋 . BTW, just changing the target will be enough 😄

@teclator teclator changed the base branch from SLE-15-GA to master September 21, 2018 12:57
@teclator teclator force-pushed the remove_susefirewall branch 2 times, most recently from d625d86 to a31c2d2 Compare October 3, 2018 10:04
@teclator
Copy link
Contributor Author

@jreidinger I resolved the current conflicts, the PR was already approved although would be nice to have a final LGTM

schubi2
schubi2 approved these changes Nov 22, 2018
View reviewed changes
Copy link
Member

@schubi2 schubi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teclator
Copy link
Contributor Author

@schubi2 thnx!

@teclator teclator merged commit ad1684f into master Nov 22, 2018
@teclator teclator deleted the remove_susefirewall branch November 22, 2018 15:23
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #9 successfully finished
✔️ Created OBS submit request #651146

@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #10 successfully finished

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #10 successfully finished
✔️ Created IBS submit request #178315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreidinger jreidinger jreidinger approved these changes

@schubi2 schubi2 schubi2 approved these changes

@imobachgs imobachgs Awaiting requested review from imobachgs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@teclator @coveralls @imobachgs @yast-bot @jreidinger @schubi2