add match preview tab 2 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
at first travis failed due to problem with compilation. Maybe it cannot find new lib you introduced. |
|
|
||
| int s, nscripts; | ||
|
|
||
| pattern = StringValueCStr(str_pattern); |
There was a problem hiding this comment.
why not simple char *pattern = StringValueCStr(str_pattern); premature initialization is not needed.
There was a problem hiding this comment.
- char *pattern = StringValueCStr(str_pattern); ok
- You mean premature initialization of res_hash? I wanted to return hash (empty or not) in any case.
There was a problem hiding this comment.
I mean char * one. For res_hash it make sense to init it to empty.
| expect(are_installed [family]).to be true | ||
| end | ||
|
|
||
| it "returns a installed family for serif alias" do |
There was a problem hiding this comment.
this is duplicite statement, maybe typo or missing word?
There was a problem hiding this comment.
copy&paste I would say :)
|
All suggestions except for three of them are implemented. |
|
No so far. |
|
OK, it would be nice to fix it, but it is not required. |
|
otherwise it looks good. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.