Pure ftp drop

.rubocop.yml

@@ -0,0 +1,109 @@
+# use the shared Yast defaults
+inherit_from:
+  /usr/share/YaST2/data/devtools/data/rubocop_yast_style.yml
+
+# Offense count: 2
+Lint/UnderscorePrefixedVariableName:
+  Exclude:
+    - 'src/modules/FtpServer.rb'
+
+# Offense count: 67
+Metrics/AbcSize:
+  Max: 268
+
+# Offense count: 4
+Metrics/BlockNesting:
+  Max: 4
+
+# Offense count: 2
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 879
+
+# Offense count: 11
+Metrics/CyclomaticComplexity:
+  Max: 115
+
+# Offense count: 90
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 153
+
+# Offense count: 79
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 479
+
+# Offense count: 4
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+  Max: 1051
+
+# Offense count: 13
+Metrics/PerceivedComplexity:
+  Max: 150
+
+# Offense count: 9
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'src/clients/ftp-server.rb'
+    - 'src/clients/ftp-server_auto.rb'
+    - 'src/include/ftp-server/complex.rb'
+    - 'src/include/ftp-server/dialogs.rb'
+    - 'src/include/ftp-server/helps.rb'
+    - 'src/include/ftp-server/wid_functions.rb'
+    - 'src/include/ftp-server/wizards.rb'
+    - 'src/include/ftp-server/write_load.rb'
+    - 'src/modules/FtpServer.rb'
+
+# Offense count: 3
+# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts.
+Style/FileName:
+  Exclude:
+    - 'src/clients/ftp-server.rb'
+    - 'src/clients/ftp-server_auto.rb'
+    - 'src/modules/FtpServer.rb'
+
+# Offense count: 14
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'src/include/ftp-server/dialogs.rb'
+    - 'src/include/ftp-server/write_load.rb'
+
+# Offense count: 7
+Style/IfInsideElse:
+  Exclude:
+    - 'src/clients/ftp-server.rb'
+    - 'src/include/ftp-server/write_load.rb'
+
+# Offense count: 168
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: snake_case, camelCase
+Style/MethodName:
+  Exclude:
+    - 'src/clients/ftp-server.rb'
+    - 'src/include/ftp-server/complex.rb'
+    - 'src/include/ftp-server/dialogs.rb'
+    - 'src/include/ftp-server/helps.rb'
+    - 'src/include/ftp-server/wid_functions.rb'
+    - 'src/include/ftp-server/wizards.rb'
+    - 'src/include/ftp-server/write_load.rb'
+    - 'src/modules/FtpServer.rb'
+
+# Offense count: 19
+Style/MultilineTernaryOperator:
+  Exclude:
+    - 'src/include/ftp-server/write_load.rb'
+
+# Offense count: 20
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: snake_case, camelCase
+Style/VariableName:
+  Exclude:
+    - 'src/clients/ftp-server.rb'
+    - 'src/include/ftp-server/helps.rb'
+    - 'src/modules/FtpServer.rb'

Rakefile

@@ -1,6 +1,6 @@
 require "yast/rake"
 
 Yast::Tasks.configuration do |conf|
-  #lets ignore license check for now
+  # lets ignore license check for now
   conf.skip_license_check << /.*/
 end

package/yast2-ftp-server.changes

@@ -1,3 +1,12 @@
+-------------------------------------------------------------------
+Thu Feb  8 15:07:37 UTC 2018 - jreidinger@suse.com
+
+- convert starting on demand from Xinetd to systemd sockets due
+  to drop of Xinetd (fate#323373)
+- Drop pure-ftp as it does not provide systemd socket and we want
+  to support only one backend to reduce the maintenance cost
+- 4.0.1
+
 -------------------------------------------------------------------
 Mon Jan 29 19:35:29 UTC 2018 - knut.anderssen@suse.com
 

package/yast2-ftp-server.spec

@@ -17,15 +17,14 @@
 
 
 Name:           yast2-ftp-server
-Version:        4.0.0
+Version:        4.0.1
 Release:        0
 
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 Source0:        %{name}-%{version}.tar.bz2
 
 # SuSEFirewall2 replace by firewalld (fate#323460)
 Requires:       yast2 >= 4.0.39
-Requires:       yast2-inetd
 BuildRequires:  update-desktop-files
 # SuSEFirewall2 replace by firewalld (fate#323460)
 BuildRequires:  yast2 >= 4.0.39
@@ -43,7 +42,7 @@ Group:          System/YaST
 
 %description
 This package contains the YaST2 component for FTP configuration. It can
-configure two daemons: pure-ftpd and vsftpd.
+configure vsftpd.
 
 %prep
 %setup -n %{name}-%{version}