Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cli #66

Merged
merged 5 commits into from
Jan 23, 2020
Merged

Fix cli #66

merged 5 commits into from
Jan 23, 2020

Conversation

jreidinger
Copy link
Member

@jreidinger jreidinger commented Jan 23, 2020 •
edited
Loading

trello: https://trello.com/c/SHhhC8TH/1598-8-wrong-error-codes-in-cli

goal: use new readonly ability and return true when action does not fail.

testing: manually

@coveralls
Copy link

coveralls commented Jan 23, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 26.313% when pulling 2956ac0 on fix_cli into 2d75ee5 on master.

@jreidinger @lslezak
Update package/yast2-ftp-server.changes
f82de4b 
Co-Authored-By: Ladislav Slezák <lslezak@suse.cz>
dgdavid
dgdavid approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. I only miss a small test for the returned value.

Thanks!

src/lib/y2ftp/clients/ftp_server.rb Show resolved Hide resolved
@jreidinger jreidinger merged commit 91b69dc into master Jan 23, 2020
@jreidinger jreidinger deleted the fix_cli branch January 23, 2020 10:19
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #7 successfully finished
✔️ Created IBS submit request #209973

@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #15 successfully finished
✔️ Created OBS submit request #766608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lslezak lslezak lslezak left review comments

@dgdavid dgdavid dgdavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jreidinger @coveralls @yast-bot @lslezak @dgdavid