Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yast2-users dependency #69

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Add yast2-users dependency #69

merged 2 commits into from
Jun 2, 2020

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Jun 2, 2020 •
edited
Loading

Problem

yast2-ftp-server requires Users module but that dependency is totally missing in the spec file.

Solution

Added dependency of yast2-users package.

Note: This dependency is not needed for testing (BuildRequires) because a stub version of Users module is used for testing (i.e., stub_module("Users")).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 26.034% when pulling c45e20d on joseivanlopez:add_users_dependency into ae04cd6 on yast:SLE-15-SP1.

@joseivanlopez joseivanlopez merged commit 3c900ca into yast:SLE-15-SP1 Jun 2, 2020
This was referenced Jun 3, 2020
Merged
Merged
@joseivanlopez
Copy link
Contributor Author

MU: https://build.suse.de/request/show/219463

@imobachgs imobachgs mentioned this pull request Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreidinger jreidinger jreidinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joseivanlopez @coveralls @jreidinger