Use string directly instead of array

An improvement from code review.
yast · Nov 25, 2021 · 666ac0d · 666ac0d
1 parent 33583f0
commit 666ac0d
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/src/include/installation/misc.rb b/src/include/installation/misc.rb
@@ -113,7 +113,7 @@ def confirmInstallation
     #
     # @return [String]
     def confirm_installation_text
-      result = []
+      result = ""
 
       result << HTML.Heading(_("Confirm Installation"))
       result << _("<p>Information required for the base installation is now complete.</p>")
@@ -125,15 +125,13 @@ def confirm_installation_text
       result << _(
         "<p>Go back and check the settings if you are unsure.</p>"
       )
-
-      result.join
     end
 
     # Text for confirmation popup before the update really starts
     #
     # @return [String]
     def confirm_update_text
-      result = []
+      result = ""
 
       result << HTML.Heading(_("Confirm Update"))
       result << _("<p>Information required to perform an update is now complete.</p>")
@@ -143,8 +141,6 @@ def confirm_update_text
           "according to the settings in the previous dialogs.</p>"
       )
       result << _("<p>Go back and check the settings if you are unsure.</p>")
-
-      result.join
     end
 
     # Label for the confirmation button before starting the installation or update process