changes from review

doc/control-file.md

@@ -859,7 +859,7 @@ and they will affect the proposed configuration of Partitioning and Software.
 A role can also define additional dialogs that are shown when a given role is
 selected. It is a common installation dialog with *Abort*, *Cancel* and *Next*
 buttons. It supports and uses all parameters from the **GetInstArgs** module.
-When going back, it will first shown the last additional dialog and when going
+When going back, it will first show the last additional dialog and when going
 back through all additional dialogs, it will show again the roles selection.
 
 They were requested in FATE#317481 and they are an evolution of the earlier

src/lib/installation/select_system_role.rb

@@ -108,6 +108,7 @@ def next_handler
 
   private
 
+    # gets array of clients to run for given role
     def additional_clients_for(role_id)
       clients = raw_roles.find { |r| r["id"] == role_id }["additional_dialogs"]
       clients ||= ""

test/select_system_role_test.rb

@@ -73,8 +73,8 @@
         expect(subject.run).to eq(:back)
       end
 
-      context "when role contain additional dialogs" do
-        it "show first dialog when going forward" do
+      context "when a role contains additional dialogs" do
+        it "shows the first dialog when going forward" do
           allow(Yast::Wizard).to receive(:SetContents)
           allow(Yast::UI).to receive(:UserInput)
             .and_return(:next)
@@ -87,7 +87,7 @@
           expect(subject.run).to eq(:next)
         end
 
-        it "shows last dialog when going back" do
+        it "shows the last dialog when going back" do
           subject.class.original_role_id = "bar"
           allow(Yast::GetInstArgs).to receive(:going_back).and_return(true)
           expect(Yast::Wizard).to_not receive(:SetContents)