Skip to content

Commit

Permalink
Renamed read_only_* functions
Browse files Browse the repository at this point in the history
  • Loading branch information
mchf committed Dec 19, 2016
1 parent 59dc802 commit 9a610c6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/lib/installation/proposal_runner.rb
Expand Up @@ -807,7 +807,7 @@ def html_header(submod)
title = @store.title_for(submod)

# do not add a link if the module is read-only or link is already included
heading = if @store.read_only_no_recovery?(submod) || title.include?("<a")
heading = if @store.hard_read_only?(submod) || title.include?("<a")
title
else
Yast::HTML.Link(title, @store.id_for(submod))
Expand Down
10 changes: 5 additions & 5 deletions src/lib/installation/proposal_store.rb
Expand Up @@ -256,10 +256,10 @@ def title_for(client)
# "soft" read-only means that the proposal is made changeable when an error
#
# @return [Boolean] true if client is "hard" or "soft" read-only
# @see read_only_no_recovery
# @see read_only_with_recovery
# @see soft_read_only
# @see hard_read_only
def read_only?(client)
read_only_no_recovery?(client) || read_only_with_recovery?(client)
hard_read_only?(client) || soft_read_only?(client)
end

# Checks if the client's proposal is configured as "hard" read-only
Expand All @@ -270,7 +270,7 @@ def read_only?(client)
#
# @param [String] client
# @return [Boolean] if the client is marked as "hard" read only
def read_only_no_recovery?(client)
def hard_read_only?(client)
read_only_proposals[:hard].include?(client)
end

Expand All @@ -282,7 +282,7 @@ def read_only_no_recovery?(client)
#
# @param [String] client
# @return [Boolean] if the client is marked as "soft" read only
def read_only_with_recovery?(client)
def soft_read_only?(client)
read_only_proposals[:soft].include?(client)
end

Expand Down

0 comments on commit 9a610c6

Please sign in to comment.