Code review fixes

doc/SELF_UPDATE.md

@@ -23,8 +23,8 @@ These are the basic steps performed by YaST in order to perform the update:
 
 ### Language Selection
 
-The self update step is exeuted before selecting the language
-(`inst_complex_welcome`). That means the self update progress and
+The self update step is executed before selecting the language
+(`inst_complex_welcome` client). That means the self update progress and
 the errors which happens during the self update process are by default displayed
 in English.
 

src/lib/installation/clients/inst_update_installer.rb

@@ -597,12 +597,12 @@ def profile_valid_scheme?
     #
     # @see Yast::Profile.current
     def current_profile
-      return nil if Yast::Profile.current == {}
+      return nil if Profile.current == {}
 
       Profile.current
     end
 
-    # Fetchs the profile from the given URI
+    # Fetch the profile from the given URI
     #
     # @return [Hash, nil] current profile if fetched or exists; nil otherwise
     #

src/lib/installation/update_repository.rb

@@ -181,6 +181,10 @@ def remove_update_files
     # Inst-sys has by default 64 loop devices, but some of them already used,
     # in an extreme case we might run out of loop devices.
     #
+    # On the other hand downloading and unpacking all packages at once might
+    # require a lot of memory, the installer could crash on a system with
+    # small memory.
+    #
     # @param mount_path [Pathname] Directory to mount the update
     #
     # @raise UpdatesNotFetched

test/inst_update_installer_test.rb

@@ -71,7 +71,7 @@ def import(_args); end
       end
     end
 
-    it "intializes the package management" do
+    it "initializes the package management" do
       # override the global stub
       expect(subject).to receive(:initialize_packager).and_call_original
 

test/update_repository_test.rb

@@ -243,7 +243,7 @@
   end
 
   describe "#cleanup" do
-    it "deletes the repository and releases it" do
+    it "deletes and releases the repository" do
       expect(Yast::Pkg).to receive(:SourceDelete).with(repo_id)
       expect(Yast::Pkg).to receive(:SourceReleaseAll)
       expect(Yast::Pkg).to receive(:SourceSaveAll)