Test the fix and the whole widget.

test/Makefile.am

@@ -34,6 +34,7 @@ TESTS = \
   system_role_test.rb \
   update_repository_test.rb \
   updates_manager_test.rb \
+  widgets_overview_test.rb \
   widgets_system_role_test.rb
 
 TEST_EXTENSIONS = .rb

test/widgets_overview_test.rb

@@ -0,0 +1,104 @@
+#! /usr/bin/env rspec
+
+require_relative "test_helper"
+
+require "installation/widgets/overview"
+
+# TODO: move these shared examples somewhere to be available to everyone
+RSpec.shared_examples "CWM::AbstractWidget" do
+  describe "#label" do
+    it "produces a String" do
+      expect(subject.label).to be_a String
+    end
+  end
+
+  describe "#handle" do
+    it "produces a Symbol or nil" do
+      expect(subject.handle(:dummy_event)).to be_a(Symbol).or be_nil
+    end
+  end
+
+  describe "#validate" do
+    it "produces a Boolean (or nil)" do
+      expect(subject.validate).to be(true).or be(false).or be_nil
+    end
+  end
+end
+
+RSpec.shared_examples "CWM::CustomWidget" do
+  include_examples "CWM::AbstractWidget"
+
+  describe "#contents" do
+    it "produces a Term" do
+      expect(subject.contents).to be_a Yast::Term
+    end
+  end
+end
+
+describe ::Installation::Widgets::Overview do
+  subject { ::Installation::Widgets::Overview.new(client: "adventure") }
+  let(:description) do
+    {
+      "menu_title" => "An Unexpected Journey"
+    }
+  end
+  let(:proposal) do
+    {
+      "label_proposal" => ["Walk to the Lonely Mountain", "Take Gold and Reign"]
+    }
+  end
+  let(:proposal_oops) do
+    {
+      "label_proposal" => ["Walk to the Lonely Mountain", "Take Gold and Reign"],
+      "warning"        => "Dragon guarding the gold, no thief in your party",
+      "warning_level"  => :fatal
+    }
+  end
+
+  before do
+    allow(Yast::WFM).to receive(:CallFunction)
+      .with("adventure", ["Description", {}])
+      .and_return(description)
+    allow(Yast::WFM).to receive(:CallFunction)
+      .with("adventure", ["MakeProposal", { "simple_mode" => true }])
+      .and_return(proposal)
+    allow(Yast::WFM).to receive(:CallFunction)
+      .with("adventure", ["AskUser", {}])
+  end
+
+  include_examples "CWM::CustomWidget"
+  context "when there is a problem" do
+    before do
+      allow(Yast::WFM).to receive(:CallFunction)
+        .with("adventure", ["MakeProposal", { "simple_mode" => true }])
+        .and_return(proposal_oops)
+    end
+
+    describe "#validate" do
+      it "returns false" do
+        subject.contents
+        expect(subject.validate).to be false
+      end
+    end
+  end
+
+  context "when there is a problem and the user corrects it" do
+    before do
+      allow(Yast::WFM).to receive(:CallFunction)
+        .with("adventure", ["MakeProposal", { "simple_mode" => true }])
+        .and_return(proposal_oops, proposal)
+    end
+
+    describe "#validate" do
+      it "first returns false, then returns true" do
+        subject.contents
+        expect(subject.validate).to be false
+
+        subject.handle(:hire_mr_baggins)
+
+        subject.contents
+        expect(subject.validate).to be true
+      end
+    end
+  end
+end