Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expert console: fixed crash in Ruby 3.1 (bsc#1195422) #1018

Merged
merged 1 commit into from Feb 2, 2022
Merged

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Feb 2, 2022

hamburger_crash

Fix

Just run the require "irb" command earlier.

Test

Tested manually in the latest TW installer, the expert console dialog it now correctly displayed.

hamburger_fixed

- Fixed crash after pressing the hamburger menu icon
  in the welcome screen
- 4.4.39
Copy link
Contributor

@shundhammer shundhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak
Copy link
Member Author

lslezak commented Feb 2, 2022

CI is failing because of some OBS issue, I'll ignore that for now...

@lslezak lslezak merged commit a6f93c5 into master Feb 2, 2022
@lslezak lslezak deleted the console_fix branch February 2, 2022 12:39
@yast-bot
Copy link
Contributor

yast-bot commented Feb 2, 2022

✔️ Public Jenkins job #211 successfully finished
✔️ Created OBS submit request #950736

@yast-bot
Copy link
Contributor

yast-bot commented Feb 2, 2022

✔️ Internal Jenkins job #118 successfully finished
✔️ Created IBS submit request #263839

@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.682% when pulling d61047e on console_fix into d3f142e on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants