Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before user sessions #1053

Merged
merged 2 commits into from Jul 22, 2022
Merged

Before user sessions #1053

merged 2 commits into from Jul 22, 2022

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Jul 22, 2022

Problem

In order to prevent a ssh timeout produced because of systemd logind we added a condition to run the SecondStage.service after systemd-user-sessions but once syste systemd logind has been patched (see systemd/systemd#23936 & https://build.suse.de/request/show/276157) our fix can be reverted removing
the Before condition.

Solution

Remove the After=systemd-user-sessions condition from the YaST2-SecondStage.service once systemd logind has been patched to prevent the ssh timeout.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.566% when pulling 24e8f83 on before_user_sessions into 3800380 on SLE-15-SP3.

Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teclator teclator merged commit cad99dd into SLE-15-SP3 Jul 22, 2022
@teclator teclator deleted the before_user_sessions branch July 22, 2022 14:37
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #20 successfully finished
✔️ Created IBS submit request #276301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants