Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default Depth for Xvnc #1071

Merged
merged 2 commits into from Dec 5, 2022
Merged

Use default Depth for Xvnc #1071

merged 2 commits into from Dec 5, 2022

Conversation

shundhammer
Copy link
Contributor

@shundhammer shundhammer commented Dec 5, 2022

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1205585

Problem

On installations using Xvnc, sometimes the font rendering is broken in the Qt UI to the point of making some fonts illegible.

wizard-welcome

See the wizard steps on the left side.

Underlying Cause

@Vogtinator found out that there is a bug in the Qt libs:

https://bugreports.qt.io/browse/QTBUG-109169

It's a bad conversion between QRgb and QRgba64 types in a gamma correct blending function.

Workaround

@Vogtinator also suggested to drop using the -depth 16 option when starting Xvnc to avoid getting into that special case. That's what this PR does.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.786% when pulling 585dda1 on huha-xvnc-default-depth into 67e74d4 on master.

Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shundhammer shundhammer merged commit 88bc3ba into master Dec 5, 2022
@shundhammer shundhammer deleted the huha-xvnc-default-depth branch December 5, 2022 10:30
@yast-bot
Copy link
Contributor

yast-bot commented Dec 5, 2022

✔️ Public Jenkins job #243 successfully finished
✔️ Created OBS submit request #1040221

@mvidner
Copy link
Member

mvidner commented Dec 5, 2022

FYI, -depth 16 was there since 2002 and I'll take my chances to simply remove it without further digging.

@yast-bot
Copy link
Contributor

yast-bot commented Dec 5, 2022

✔️ Internal Jenkins job #141 successfully finished
✔️ Created IBS submit request #285739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants