Connect only nbft #1078
Merged
Connect only nbft #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwilck
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
This is correct. Currentlynvme connect-all does not imply connect-nbft. (This may change in the future). connect-all would only consider locally configured NVMeoF connections (regular or discovery subsystems), and because no such thing exists at this early stage, would basically be a no-op.
connect-nbft is correct.
imobachgs
approved these changes
Jan 25, 2023
|
✔️ Public Jenkins job #249 successfully finished |
|
✔️ Internal Jenkins job #145 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It was requested to use
nvme connect-nbftwhen UseNBFT was set by linuxrc but we callnvme connect-all.Solution
Implement the call as requested (it depends on https://build.suse.de/request/show/288814)