In zVM || KVM write the cio_kernel_parameter only if given #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teclator
force-pushed
the
cio_ignore_when_given
branch
from
2647fcb
to
bd833ee
Compare
jreidinger
reviewed
Jan 26, 2024
src/lib/installation/cio_ignore.rb
Outdated
| def zvm? | ||
| File.exist?("/proc/sysinfo") && | ||
| File.readlines("/proc/sysinfo").grep(/Control Program: z\/VM/).any? | ||
| end |
There was a problem hiding this comment.
Instead of adding back this method I suggest to use shared functionality from Yast::Arch - https://github.com/yast/yast-yast2/blob/d6ae8689e2ea9abf9908c1c9bd76c3dd557f78cf/library/general/src/modules/Arch.rb#L440
jreidinger
approved these changes
Jan 27, 2024
|
✔️ Internal Jenkins job #153 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change #1104 implementation writing the cio_ignore kernel parameter only if given according to the bug request. It depends on yast/yast-yast2#1300