Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop fbiterm in Tumbleweed Installation #1117

Merged
merged 5 commits into from
May 27, 2024
Merged

Drop fbiterm in Tumbleweed Installation #1117

merged 5 commits into from
May 27, 2024

Conversation

shundhammer
Copy link
Contributor

@shundhammer shundhammer commented May 14, 2024

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1224053

Trello

https://trello.com/c/haqsYySu

Problem

We are using fbiterm for much improved support for nontrivial locales like Chinese, Japanese, Korean in NCurses. But fbiterm is part of the xiterm package (it's the framebuffer version of xiterm, hence FB-Iterm) which has been abandoned upstream many years ago. With the upcoming GCC 14, it has build problems. The maintainer of the xiterm package feels unable to continue supporting it; so we need to drop the xiterm package and with it fbiterm.

Fix

  • Don't require xiterm in the YaST packages anymore.
    It turns out we never required xiterm or fbiterm in any YaST package: We always checked at runtime if /usr/bin/fbiterm was available and used it only if it was.

  • Don't use fbiterm in the YaST startup scripts anymore.
    Strictly speaking, we could simply rely on the check if it was available, but this PR cleans up a lot of legacy that goes back a long time, and that obscured the code in the startup scripts.

Caveat

Installing in certain languages won't work anymore in NCurses (text mode). Those languages will use a fallback to English from now on; but only in NCurses. The Qt (graphical) installation will work as before.

Target Distributions

For now, only Tumbleweed / Factory / YaST master is affected. SLE-15 SPx and SLE-12 SPx will retain fbiterm.

Test

Manual test in a modified inst-sys with the new scripts

@coveralls
Copy link

coveralls commented May 14, 2024

Coverage Status

coverage: 41.105%. remained the same
when pulling 2efeda0 on huha-no-fbiterm
into 68180ad on master.

@shundhammer
Copy link
Contributor Author

See also openSUSE/installation-images#708

@shundhammer shundhammer marked this pull request as ready for review May 23, 2024 13:26
@shundhammer shundhammer requested a review from wfeldt May 23, 2024 13:51
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shundhammer shundhammer merged commit e896d3b into master May 27, 2024
12 checks passed
@shundhammer shundhammer deleted the huha-no-fbiterm branch May 27, 2024 08:43
Copy link

❌ Autosubmission job #9251920803 failed

@shundhammer
Copy link
Contributor Author

@lslezak : This is the example for CI via GitHub failing because the image doesn't have /bin/diff.

@shundhammer
Copy link
Contributor Author

Submitted manually with rake osc:sr to OBS openSUSE:Factory:

https://build.opensuse.org/request/show/1177300

@lslezak
Copy link
Member

lslezak commented May 28, 2024

I have added the diffutils to the container image. Looks like it was removed from the base container, recently I had to add it elsewhere too...

Copy link

✅ Autosubmission job #9251920803 successfully finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants