Poc recover values #319
Closed
Poc recover values #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, I'm just thinking whether it would make sense to share the storing/loading the reusable data in some base class. Is something planned? Something similar to what we already have for the proposal clients (proposal_client.rb)... |
|
@lslezak I also consider it, but there is only few clients need it and in the end it is simple Yaml based storing. |
|
Good point @lslezak I'd like to see the data at one place using one API. It might be YAML, but with a shared interface, 0.02 EUR |
teclator
added a commit
to teclator/yast-installation
that referenced
this pull request
Mar 11, 2016
teclator
added a commit
to teclator/yast-installation
that referenced
this pull request
Mar 14, 2016
teclator
added a commit
to teclator/yast-installation
that referenced
this pull request
Mar 14, 2016
teclator
added a commit
to teclator/yast-installation
that referenced
this pull request
Mar 15, 2016
teclator
added a commit
to teclator/yast-installation
that referenced
this pull request
Mar 15, 2016
|
This was implemented in #348 as part of fate#319716, so I'm closing this PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not to merge yet ( planned for SP2 ) and now only RFC way how to handle reusable data.