Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped disk activation step in case of installer updated (bsc#974409) #367

Merged
merged 5 commits into from
Apr 22, 2016

Conversation

teclator
Copy link
Contributor

During the tests i realized that the license agreement was not remembered so i also fix it.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 01c4e8e on teclator:disk_activation into * on yast:master*.

@@ -55,6 +58,10 @@ def main
@have_zfcp = false
@want_fcoe = false

@installer_update ||= InstUpdateInstaller.new
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird use of a client. Is strange to have a client (something that is usually only meant to be executed) with the responsibility of knowing if the installer is updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better solution discussed offline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice discussion ;)

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling abf028a on teclator:disk_activation into * on yast:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ac033ed on teclator:disk_activation into * on yast:master*.

@teclator
Copy link
Contributor Author

This PR's are related to this one

yast/yast-yast2#463
yast/yast-packager#155

@@ -26,6 +26,9 @@
#
# $Id$
#

require "installation/clients/inst_update_installer"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

@ancorgs
Copy link
Contributor

ancorgs commented Apr 22, 2016

Besides the surplus require, looks good.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 821e3e4 on teclator:disk_activation into * on yast:master*.

@teclator teclator merged commit 8c3552d into yast:master Apr 22, 2016
teclator added a commit that referenced this pull request Apr 29, 2016
Document new restarting flag and Resume Installation (#367)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants