-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skipped disk activation step in case of installer updated (bsc#974409) #367
Conversation
Changes Unknown when pulling 01c4e8e on teclator:disk_activation into * on yast:master*. |
@@ -55,6 +58,10 @@ def main | |||
@have_zfcp = false | |||
@want_fcoe = false | |||
|
|||
@installer_update ||= InstUpdateInstaller.new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird use of a client. Is strange to have a client (something that is usually only meant to be executed) with the responsibility of knowing if the installer is updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A better solution discussed offline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice discussion ;)
Changes Unknown when pulling abf028a on teclator:disk_activation into * on yast:master*. |
abf028a
to
ac033ed
Compare
Changes Unknown when pulling ac033ed on teclator:disk_activation into * on yast:master*. |
This PR's are related to this one |
@@ -26,6 +26,9 @@ | |||
# | |||
# $Id$ | |||
# | |||
|
|||
require "installation/clients/inst_update_installer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
Besides the surplus require, looks good. |
Changes Unknown when pulling 821e3e4 on teclator:disk_activation into * on yast:master*. |
Document new restarting flag and Resume Installation (#367)
During the tests i realized that the license agreement was not remembered so i also fix it.