Add dashboard role handler #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teclator
approved these changes
Mar 23, 2017
|
Thanks for the review! :) |
jreidinger
reviewed
Mar 23, 2017
| # ------------------------------------------------------------------------------ | ||
|
|
||
| require "yast" | ||
| require "installation/cfa/salt" |
There was a problem hiding this comment.
why it is needed here??? It is for worker role only, so it should be in that file.
There was a problem hiding this comment.
You're right. I'll fix it (without version bumping) and anyway I'll remove it when merging into master.
|
@imobachgs Just a side note: This really looks like something not generic enough, something that probably belongs to a CaaSP-specific package. But it's just an opinion to consider... |
|
@kobliha Yes, it sounds good: we could move those roles handlers to a |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://trello.com/c/PJqM8x0T for details.
CaaSP deserves its own YaST package!
Among other things, our team is working hard to make YaST fulfill the requirements of the upcoming Containers as a Service Platform (CaaSP) product. As part of this effort, we have added some new features, discovered (and fixed) some bugs, improved documentation and so on.
We've also added some specific CaaSP code, so during this sprint we've decided to create a new dedicated package (yast2-caasp) and move the it there.
Currently it only contains system role handlers and some additional documentation, but most probably we will add some stuff within the upcoming months.