-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable plymouth by a no affend method, it will not block tty device activation at first time user login(bsc#1042554). #584
Conversation
package/yast2-installation.changes
Outdated
- Update YaST2-Firstboot.service: Depreciate plymouth --wait, add | ||
conflict to plymouth start service. | ||
- Update YaST2-Second-Stage.service: Depreciate plymouth deactivate | ||
command and add conflict to plymouth start service. For they will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"For they"? What about something like "For that" or just "TTY device activation will be blocked."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove package/.yast2-installation.changes.swp
and bump package version in package/yast2-installation.spec
changes.
From the technical point of view, I would like to ask @wfeldt about his opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a high level description to the pr.
The title says 'enable tty activation' but what the pr does, afaiui, is to disable plymouth.
While the latter is always a good thing :-), it would look good to motivate this a bit.
@wfeldt , Could you give me some advice about the latest modification ? |
…activation at first time user login(bsc#1042554).
@imobachgs @wfeldt you both approved the PR but it has not been merged. Now there's a conflict in changes files - as expected after some time - but is there a specific reason why the PR is not merged? That fix should have gone into SLE 12 SP3 but therefore failed to do so. I am wondering if there is something wrong in this PR or if it was just overlooked? |
Superseded by #642. It is the same, bug fixing a problem in the changes file. Thanks! |
No description provided.