Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable plymouth by a no affend method, it will not block tty device activation at first time user login(bsc#1042554). #584

Closed
wants to merge 3 commits into from

Conversation

qiangzhao
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 17.211% when pulling b5a4c4b on qiangzhao:master into bc707bc on yast:master.

- Update YaST2-Firstboot.service: Depreciate plymouth --wait, add
conflict to plymouth start service.
- Update YaST2-Second-Stage.service: Depreciate plymouth deactivate
command and add conflict to plymouth start service. For they will
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"For they"? What about something like "For that" or just "TTY device activation will be blocked."

Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove package/.yast2-installation.changes.swp and bump package version in package/yast2-installation.spec changes.

From the technical point of view, I would like to ask @wfeldt about his opinion.

Copy link
Member

@wfeldt wfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a high level description to the pr.

The title says 'enable tty activation' but what the pr does, afaiui, is to disable plymouth.

While the latter is always a good thing :-), it would look good to motivate this a bit.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 17.211% when pulling 82779db on qiangzhao:master into bc707bc on yast:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 17.211% when pulling 05706e5 on qiangzhao:master into bc707bc on yast:master.

@qiangzhao qiangzhao changed the title Enable tty device activation at first time rebooting (bsc#1042554). Disable plymouth by a no affend method, it will not block tty device activation at first time user login(bsc#1042554). Jul 7, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 17.211% when pulling 864139d on qiangzhao:master into bc707bc on yast:master.

@qiangzhao
Copy link
Contributor Author

@wfeldt , Could you give me some advice about the latest modification ?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 17.788% when pulling 8a9cb95 on qiangzhao:master into bc707bc on yast:master.

…activation at first time user login(bsc#1042554).
@coveralls
Copy link

Coverage Status

Coverage remained the same at 17.788% when pulling 354262d on qiangzhao:master into 8782455 on yast:master.

@okurz
Copy link
Contributor

okurz commented Aug 21, 2017

@imobachgs @wfeldt you both approved the PR but it has not been merged. Now there's a conflict in changes files - as expected after some time - but is there a specific reason why the PR is not merged? That fix should have gone into SLE 12 SP3 but therefore failed to do so. I am wondering if there is something wrong in this PR or if it was just overlooked?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 18.393% when pulling 08a7f6a on qiangzhao:master into 0660715 on yast:master.

@imobachgs
Copy link
Contributor

Superseded by #642. It is the same, bug fixing a problem in the changes file. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants