Provide icon with module (boo#1109310) #765
Conversation
| @@ -0,0 +1,10 @@ | |||
| [Desktop Entry] | |||
There was a problem hiding this comment.
AFAICS these new .desktop files are needed just because of the Wizard.SetDesktopTitleAndIcon("installation") call, right?
The YaST control center still reads that prints this warning and ignores the file:
Warning: Skipping file "/usr/share/applications/YaST2/installation.desktop" : missing group
attribute (X-SuSE-YaST-Group)
Adding
Hidden=true
avoids that warning and that should also help to not display it in the other software by mistake.
There was a problem hiding this comment.
Did that, although I am still not happy about the requirement of having desktop files for icons. It's a neat feature, but it should be an addition to real icon loading.
There was a problem hiding this comment.
Yes, using icons should be possible even without a desktop file.
Please open a separate bug for that so we can improve that.
src/desktop/installation.desktop
Outdated
| Categories=Settings;System;Qt; | ||
|
|
||
| Icon=yast-installation | ||
| Exec= |
There was a problem hiding this comment.
I'm not sure, maybe this violates the desktop file standard: "The Exec key must contain a command line.", see https://standards.freedesktop.org/desktop-entry-spec/latest/ar01s07.html for more details.
Although it's not a real problem, some OBS checks could complain in the future. I'm not a desktop file expert, but maybe using a /bin/true dummy value here could be a good idea.
When I tried to build the package locally I got these errors:
ERROR: No sufficient Category definition: /home/abuild/rpmbuild/BUILDROOT/yast2-installation-4.1.30-1.x86_64//usr/share/applications/YaST2/installation.desktop
Please refer to https://en.opensuse.org/openSUSE:Packaging_desktop_menu_categories
WARNING: Empty GenericName: /home/abuild/rpmbuild/BUILDROOT/yast2-installation-4.1.30-1.x86_64//usr/share/applications/YaST2/installation.desktop
ERROR: No sufficient Category definition: /home/abuild/rpmbuild/BUILDROOT/yast2-installation-4.1.30-1.x86_64//usr/share/applications/YaST2/upgrade.desktop
Please refer to https://en.opensuse.org/openSUSE:Packaging_desktop_menu_categories
WARNING: Empty GenericName: /home/abuild/rpmbuild/BUILDROOT/yast2-installation-4.1.30-1.x86_64//usr/share/applications/YaST2/upgrade.desktop
Errors in installed desktop file detected. Please refer to http://en.opensuse.org/SUSE_Package_Conventions/RPM_Macros
For some reason this check is not executed at Travis so it does not fail, I'll check if that could be improved...
|
|
||
| Name=Installation | ||
| GenericName=System Upgrade | ||
| Comment=Install system to the system |
There was a problem hiding this comment.
Ah, something like "Install a new system" would be better here, but as this is just a dummy desktop file it does not matter much...
There was a problem hiding this comment.
Ah, miss on my part, I hope to remove those desktop files as soon as I patch YaST with a way to load icons directly.
|
✔️ Public Jenkins job #33 successfully finished |
|
✔️ Internal Jenkins job #35 successfully finished |
No description provided.