Stop using obsolete XVersion; check textdomain presence #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mvidner
commented
Mar 6, 2019
| @@ -460,7 +457,6 @@ set_syslog ; set_proxy | |||
| #--------------------------------------------- | |||
| # 2.1) setup PATH | |||
| PATH=$ybindir:$PATH | |||
| [ -z Xstartpath ] || PATH=/var/X11R6/bin:$PATH | |||
There was a problem hiding this comment.
BTW this line has prompted the cleanup: ShellCheck correctly notes that we are testing a nonempty literal for emptiness (a $ is missing)
jreidinger
approved these changes
Jul 25, 2019
Back in 2006 SUSE Linux was migrating from XFree86 to X.org which used different filesystem paths, so YaST got an internal config file to manage the transition. It is time to delete that obsolete code.
mvidner
changed the title
|
✔️ Public Jenkins job #63 successfully finished |
|
✔️ Internal Jenkins job #4 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was useful in 2006 when X.org 6 and X.org 7 had different places for files
textdomain: